app/src/main/java/app/gamenative/ui/screen/library/LibraryAppScreen.kt (3)

523-524: 💤 Low value

Unused parameter: achievementsAppId is declared but never referenced.

The achievementsAppId parameter is passed to AppScreenContent but not used anywhere in the function body. Either remove it or document its intended future use.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/main/java/app/gamenative/ui/screen/library/LibraryAppScreen.kt`
around lines 523 - 524, The parameter achievementsAppId in the AppScreenContent
signature is unused; remove the achievementsAppId parameter from the
AppScreenContent function declaration and any callers that pass
achievementsAppId (or, if intended for future use, add a clear TODO/KDoc
explaining its planned role and reference it in the body). Update the function
signature that currently lists "achievements: List<Achievement>? = null,
achievementsAppId: Int? = null" to drop achievementsAppId and remove its usage
from the call sites (or replace with documented placeholder) so there are no
unused parameters.

---

1314-1321: 💤 Low value

Hardcoded content description should use a string resource.

The content description "Star" is hardcoded in English. For accessibility and localization consistency, use a string resource.

💬 Suggested fix

                     Icon(
                         imageVector = Icons.Filled.Star,
-                        contentDescription = "Star",
+                        contentDescription = stringResource(R.string.achievements_complete),
                         tint = Color(0xFFFFD700),
                         modifier = Modifier.size(16.dp),
                     )

Add to strings.xml:

<string name="achievements_complete">All achievements unlocked</string>

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/main/java/app/gamenative/ui/screen/library/LibraryAppScreen.kt`
around lines 1314 - 1321, Replace the hardcoded contentDescription "Star" used
with the Icon (Icons.Filled.Star) by loading a string resource (e.g.
stringResource(R.string.achievements_complete)) and add the corresponding entry
in strings.xml (name="achievements_complete") so the contentDescription is
localized; ensure the composable imports androidx.compose.ui.res.stringResource
and use that resource in the Icon's contentDescription within LibraryAppScreen
(or the composable containing the Icon).

---

1404-1404: 💤 Low value

Achievement.getFormattedUnlockTime parameter is duplicative

Achievement.getFormattedUnlockTime(unlockTimestamp: Int) requires the parameter, so the call ach.getFormattedUnlockTime(ach.unlockTimestamp) is correct; the duplication is that the method ignores this.unlockTimestamp and just formats the passed value. Consider changing the API to getFormattedUnlockTime(): String? (or using this.unlockTimestamp) to remove the redundant argument.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/main/java/app/gamenative/ui/screen/library/LibraryAppScreen.kt` at
line 1404, The method Achievement.getFormattedUnlockTime currently takes
unlockTimestamp as a parameter but callers pass ach.unlockTimestamp (e.g.,
ach.getFormattedUnlockTime(ach.unlockTimestamp)), creating a redundant API; fix
by removing the parameter and switching the implementation to use
this.unlockTimestamp (or alternatively update callers to pass the value
consistently) so the signature becomes getFormattedUnlockTime(): String? and
update all call sites like ach.getFormattedUnlockTime() (search for
Achievement.getFormattedUnlockTime and unlockTimestamp usage to update
implementation and callers).

app/src/main/java/app/gamenative/ui/screen/library/appscreen/BaseAppScreen.kt (1)

930-943: 💤 Low value

Consider adding error handling for achievement fetching.

If fetchAchievementsForDisplay throws an exception, the coroutine will fail and achievementsState remains null. While this gracefully hides the achievements section, logging the error would help with debugging.

🛡️ Suggested improvement

         LaunchedEffect(libraryItem.gameId) {
             when(libraryItem.gameSource){
                 GameSource.STEAM -> {
-                    achievementsState = withContext(Dispatchers.IO) {
-                        app.gamenative.service.SteamService.fetchAchievementsForDisplay(libraryItem.gameId)
+                    achievementsState = try {
+                        withContext(Dispatchers.IO) {
+                            app.gamenative.service.SteamService.fetchAchievementsForDisplay(libraryItem.gameId)
+                        }
+                    } catch (e: Exception) {
+                        Timber.d(e, "Failed to fetch achievements for game ${libraryItem.gameId}")
+                        null
                     }
                 }
                 GameSource.EPIC -> { } // Add later with Epic achievements
                 GameSource.GOG -> { } // Add later with GOG achievements
                 GameSource.AMAZON -> { }
                 GameSource.CUSTOM_GAME -> { }
             }
         }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@app/src/main/java/app/gamenative/ui/screen/library/appscreen/BaseAppScreen.kt`
around lines 930 - 943, Wrap the call to
app.gamenative.service.SteamService.fetchAchievementsForDisplay inside a
try/catch within the LaunchedEffect(libraryItem.gameId) block so exceptions
don’t crash the coroutine; on failure catch the Throwable, set achievementsState
to a safe fallback (null or empty list) and log the error (use your app logger
or Log/Timber) including libraryItem.gameId and the exception message so you can
debug; apply the same pattern for other GameSource branches when implemented.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes